S3_1 load_ruleset_veteran() clang analyzer warning

• Rapporteur: cazfi
• Propriétaire: cazfi
• Type: Bogues
• État: Atteints
• Composant: Server
• Jalon: 3.1.0-beta2 (atteints)
• Priorité: 5 - moyen
• Sévérité: 5 - moyen
• Résolution: Fixed
• Fichier: 1

Détails

S3_1:

---

../../../src/server/ruleset.c:2010:26: warning: Array access (from variable 'vlist_raise') results in a null pointer dereference [core.NullDereference]
(vlist_raise[i] < 0), vlist_raise[i] = 0);
../../../src/server/ruleset.c:1998:7: note: expanded from macro 'rs_sanity_veteran'
if (_condition) {

---

That it warns only about vlist_raise, and not about the other arrays hints that the problem is with the compat handling in S3_1 (update from 3.0 to 3.1). I don't see real bug there, as 'count_raise' will be set to zero by secfile_lookup_int_vec() when ever it returns NULL. Compiler just doesn't know it, but seeing that check against NULL only in compat mode makes it think that NULL might live on in non-compat mode.

Ticket History (3/4 Histories)

2023-04-03 12:42 Updated by: cazfi

• New Ticket "S3_1 load_ruleset_veteran() clang analyzer warning" created

2023-04-03 13:22 Updated by: cazfi

• File 0018-Never-accept-veteran_raise_chance-from-3.1-ruleset.patch (File ID: 12064) is attached

2023-04-03 13:22 Updated by: cazfi

• Propriétaire Update from (Aucun) to cazfi
• Résolution Update from Aucun to Accepted

Commentaire

But those lines had another bug - namely that compatibility mode check was not strict enough.

Patch for S3_1 attached.

2023-04-05 17:51 Updated by: cazfi

• État Update from Ouvert to Atteints
• Résolution Update from Accepted to Fixed