load_action_range_max() passing NULL as string

• Rapporteur: cazfi
• Propriétaire: cazfi
• Type: Bogues
• État: Atteints
• Composant: Server
• Jalon: 3.1.0-beta4 (atteints)
• Priorité: 5 - moyen
• Sévérité: 5 - moyen
• Résolution: Fixed
• Fichier: 2

Détails Répondre

load_action_range_max() handles all actions, including those for which action_max_range_ruleset_var_name() returns NULL. Yet it does 'secfile_entry_lookup(file, "actions.%s", action_max_range_ruleset_var_name(act));'

Haven't checked the other handling of other similar ruleset entries for actions. It's possible that this is a common bug-pattern.

Ticket History (3/7 Histories)

2023-04-09 00:35 Updated by: cazfi

• New Ticket "load_action_range_max() passing NULL as string" created

2023-09-18 10:54 Updated by: cazfi

Commentaire Répondre

The function is actually only called when there's var name, but this should still be refactored to avoid the duplicate call.

2023-09-18 11:04 Updated by: cazfi

• File 0026-load_action_range_max-Avoid-duplicate-var-name-detec.patch (File ID: 13229) is attached

2023-09-18 11:09 Updated by: cazfi

• File 0018-load_action_range_max-Avoid-duplicate-var-name-detec.patch (File ID: 13230) is attached

2023-09-18 11:10 Updated by: cazfi

• Propriétaire Update from (Aucun) to cazfi
• Résolution Update from Aucun to Accepted
• Jalon Update from (Aucun) to 3.1.0-beta4 (atteints)

2023-09-22 21:35 Updated by: cazfi

Commentaire Répondre

Pushed to branches other than S3_1. S3_1 will wait for 3.1.0-beta3 release first.

2023-09-30 06:45 Updated by: cazfi

• État Update from Ouvert to Atteints
• Résolution Update from Accepted to Fixed