Ticket #48283

EMERGENCY_VERSION redefinition in autotools builds

Date d'ouverture: 2023-06-24 16:54 Dernière mise à jour: 2024-03-01 09:42

Rapporteur:
Propriétaire:
Type:
État:
Ouvert [Owner assigned]
Composant:
Jalon:
Priorité:
5 - moyen
Sévérité:
5 - moyen
Résolution:
Aucun
Fichier:
1

Détails

Generated version_gen.h might unconditionally redefine EMERGENCY_VERSION. Autotools based builds do it on configure too.

Ticket History (3/9 Histories)

2023-06-24 16:54 Updated by: cazfi
  • New Ticket "EMERGENCY_VERSION redefinition in autotools builds" created
2023-06-24 17:22 Updated by: cazfi
Commentaire

More serious side of this: Other parts of the code assume that EMERGENCY_VERSION information is correctly available from fc_config.h, but it's not in case of Meson based builds.

2023-06-24 17:44 Updated by: cazfi
Commentaire

Reply To cazfi

More serious side of this: Other parts of the code assume that EMERGENCY_VERSION information is correctly available from fc_config.h, but it's not in case of Meson based builds.

This is actually avoided by having meson generated fc_config.h to include version_gen.h.

So, maybe all the issues are currently on autotools side (but fixing those might still require touching meson side too, to not break it)

2023-06-24 18:03 Updated by: cazfi
  • Propriétaire Update from (Aucun) to cazfi
  • Résolution Update from Aucun to Accepted
2023-06-26 23:16 Updated by: cazfi
  • Résolution Update from Accepted to Aucun
Commentaire

This seems to break installer_cross / autotools build quite badly. Have to investigate. Seems like there's a dormant issue that version_gen.h is not generated the way it should. As this fix makes the build to rely more on version_gen.h, those issues unearth.

2024-03-01 09:42 Updated by: cazfi

Modifier

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Connexion