#44461: citizen_set segfault with alien/alio
Open Date: 2022-04-25 01:10
Last Update: 2022-04-25 15:33
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44461
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44461
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-04-25 15:33 Updated by: cazfi
* Resolution Update from None to Accepted
Comment:
Reply To cazfi
The current patch breaks the opposite, and more common case, that the ruleset is *not* sent after tileset load.
That was because of tileset_setup_city_tiles() refusing to handle anything but the current last style - when style count has already gone up there was no handling earlier ones.
Attached patch is a quick fix. No refactoring for that design at this point. Should work for both cases now.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.2.0
Component: Client common
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
Starting alien ruleset game, accepting the tileset suggestion (don't know if it's relevant that the tileset was not correct one to begin with), and then trying to add an ocean city in editor mode (maybe relevant: in my tests the only ocean tiles revealed by initial vision radius were under FoW) -> client crash.
get_citizen_sprite (t=0x55555d485e50, type=CITIZEN_CONTENT, citizen_index=<optimized out>,
pcity=pcity at entry=0x55555e42ec00) at ../../../src/client/tilespec.c:6516
6516 if (graphic == NULL || graphic->count == 0) {
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44461
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44461